node-theseus icon indicating copy to clipboard operation
node-theseus copied to clipboard

things don't work right when some files are in symlinked directories (on mac)

Open joelrbrandt opened this issue 12 years ago • 2 comments

Steps to reproduce:

  1. make directories foo and `bar`` at different places in your fs
  2. symlink bar into foo (so you have "/full/path/to/foo/bar/")
  3. put JS files foo.js in directory foo and bar.js in directory bar
  4. do require("/full/path/to/foo/bar/bar.js") in foo.js
  5. Experience Theseus not logging anything in bar.js

joelrbrandt avatar Jul 25 '13 17:07 joelrbrandt

When Theseus is used on files in Chrome, it has to map URLs to file paths by guessing. For this, Agent.js defines possibleRemotePathsForLocalPath(path) that returns an array of likely URLs for a given file path, and that list is used to determine whether Theseus should show pills for a given file.

I think this function should be augmented to also add the file's fully resolved path to the list. This way, whether you open the file at the original path, or the symlinked path, Theseus will still show the pills.

Now to check whether Brackets wraps that call!

alltom avatar Jul 25 '13 20:07 alltom

Nope.

alltom avatar Jul 25 '13 21:07 alltom