source-serif icon indicating copy to clipboard operation
source-serif copied to clipboard

trailing space in LICENSE.md line 65

Open tspiteri opened this issue 2 years ago • 3 comments

Line 65 of the license file ending in "can be bundled, embedded, " has a trailing space. (I'm only bringing this nit up as I had to update this to appease format checkers in another project.)

Also, is there a reason why source-serif-4.005_Desktop.zip includes the license file but source-serif-4.005_WOFF.zip and source-serif-4.005_WOFF2.zip do not?

tspiteri avatar Jan 27 '23 14:01 tspiteri

Thanks for the report, I have to make a new release soon, and will include the license in all downloadable packages.

There is no reason for the license file missing in some of the downloads – it is the first time I package the license alongside the fonts (beyond having it in the release branch), this happens automatically upon building the fonts. The web font conversion simply does not copy over the license file to the respective folders.

(Why so many copies of the same file, if the OFL is linked within the fonts’ metadata? @mbutterick ?) See also https://github.com/adobe-fonts/source-serif/issues/107

frankrolf avatar Jan 27 '23 15:01 frankrolf

Why so many copies of the same file, if the OFL is linked within the fonts’ metadata?

Personally I'm fine with it just in source-serif-4.005R.zip and I don't have a preference either way in the _Desktop, _WOFF and _WOFF2 zips; I just found it inconsistent that _Desktop had it while _WOFF and _WOFF2 didn't.

tspiteri avatar Jan 27 '23 15:01 tspiteri

The LICENSE.md has been updated in both development and release branches, and will therefore make it into the next build of Source Serif (no timeline yet).

frankrolf avatar Aug 23 '23 09:08 frankrolf