webhook icon indicating copy to clipboard operation
webhook copied to clipboard

Published 20 hours ago • verified publisher icon adnanh

Add support for Scalr webhook signature verification

Open moorereason opened this issue 7 years ago • 12 comments

Requested by @hassanbabaie in https://github.com/adnanh/webhook/issues/197#issuecomment-345341247.

Ref: https://github.com/scalr-tutorials/webhook

moorereason avatar Nov 20 '17 16:11 moorereason

Thanks for creating this ticket, I've reached out to Aloys (who did the original fork for us) to see if he can do a PR against the Development branch

hassanbabaie avatar Nov 21 '17 18:11 hassanbabaie

@moorereason & @adnanh Just to confirm, I've finished the tests with the code I copied over from @AloysAugustin fork and will start my pull request today. I might do it wrong, so don't hesitate to let me know. I plan to commit the code changes and then if all good I will propose some help document updates

hassanbabaie avatar Dec 19 '17 16:12 hassanbabaie

PR kicked off: Add support for Scalr webhook signature verification (new Match Rule) #200 #209

hassanbabaie avatar Dec 19 '17 16:12 hassanbabaie

Hi @adnanh do you think my pull request (210) might make it into the next release? Also I would be interested in your thoughts on @dcj log file one

Thanks

Hass

hassanbabaie avatar Jan 04 '18 15:01 hassanbabaie

Hey @hassanbabaie, I'll review it as soon as I get some free time :-)

adnanh avatar Jan 04 '18 17:01 adnanh

That's great, thanks!

hassanbabaie avatar Jan 04 '18 18:01 hassanbabaie

Hi @adnanh I was looking at the Wiki to determine which ones to update and my thoughts are that I would add a section in Hook Examples with example and extra information and also a section in Hook rules

Let me know if this makes sense and I should have the PR done today

hassanbabaie avatar Jan 18 '18 18:01 hassanbabaie

@adnanh,

What are we doing with the wiki going forward? We moved the documentation into the docs folder. Can the wiki be deleted?

@hassanbabaie,

  1. Yes, add a section in Hook Examples.
  2. Also document the new scalr-signature Match type in Hook Rules.

moorereason avatar Jan 18 '18 18:01 moorereason

thanks!

hassanbabaie avatar Jan 18 '18 19:01 hassanbabaie

PR 218 submitted for document updates

hassanbabaie avatar Jan 18 '18 20:01 hassanbabaie

@moorereason I would replace the contents of the wiki pages with a link to the appropriate docs page, so if anyone bookmarked the wiki link will know where to go... What do you think?

adnanh avatar Jan 19 '18 16:01 adnanh

Hi @moorereason @adnanh did you get a chance to look at the help document PR I did? Also do we have an idea when 2.6.9 might be released (with maybe my Scalr bit...)?

Thank you for your help

regards

Nagging Hass!

hassanbabaie avatar Jan 30 '18 01:01 hassanbabaie