EPIJudge icon indicating copy to clipboard operation
EPIJudge copied to clipboard

Published 20 hours ago • verified publisher icon adnanaziz

Using list of characters instead of a string for Problem 24.8 #151

Open deveshks opened this issue 5 years ago • 4 comments

Updated code to use a list of characters instead of a string to represent an added word for Problem 24.8 in order to avoid the extra time complexity associated with string concatentations

$ python3.7 epi_judge_python_solutions/left_right_justify_text.py Test PASSED (30/30) [ 15 us] Average running time: 37 us

deveshks avatar Jan 14 '20 18:01 deveshks

Hi @tsunghsienlee, @adnanaziz, @metopa

I have submitted a PR to outline my fix for issue https://github.com/adnanaziz/EPIJudge/issues/151.

Please review the same at your convenience and I will address any concerns with the same in the PR

deveshks avatar Jan 20 '20 08:01 deveshks

Generally it looks good to me, and I probably will omit get_strings function but it is definitely personal choice. This will be merge later.

tsunghsienlee avatar Jan 27 '20 03:01 tsunghsienlee

Hi @tsunghsienlee

Hope you are doing well. I just saw that this PR has been sitting in an open state since a few months now. May I know when do you plan to merge this PR to master?

deveshks avatar May 09 '20 08:05 deveshks

@deveshks Hi there, sorry for the long wait. I'll check this out right after I do my state exams at the end of June. I'll keep you updated :)

metopa avatar Jun 07 '20 08:06 metopa