admin-theme icon indicating copy to clipboard operation
admin-theme copied to clipboard

Upgrade bootstrap 4

Open fif10 opened this issue 7 years ago • 6 comments

Hello

I just wanted to know if there is any plan to upgrade to bootstrap 4.

Thanks a lot for the great work.

fif10 avatar Jan 06 '18 07:01 fif10

Hi there, AdminFaces is based on AdminLTE which is not compatible with BS 4 at moment, follow this issue for more details: https://github.com/almasaeed2010/AdminLTE/issues/710

So unfortunately we'll not be able to upgrade right now but as soon AdminLTE brings BS4 support we can start working on this.

Just out of curiosity, what features of BS4 you're missing the most right now?

rmpestano avatar Jan 06 '18 12:01 rmpestano

Hi

Thank you for your reply.

Not really missing features, but my concern was mainly to use bs3 features (or custo usage) incompatible with bs4 if you were about to release soon. (was also alot of curiosity :=))

Thanks a lot.

fif10 avatar Jan 07 '18 11:01 fif10

I understand that the admin-theme is based on admin lite. But I could throw a theme apart with bootstrap 4. just incorporating the same css. without anything from admin lite.

rruffer avatar Jan 09 '19 14:01 rruffer

Hi @rruffer,

so the without bootstap classifier plus BS4, works for you?

To be honest I've never tried BS4, if replacing BS3 with 4 don't break existing applications then I have no problems in upgrading and would accept PRs.

Thanks for weighing in.

rmpestano avatar Jan 09 '19 14:01 rmpestano

It is an option. I'll test. But I believe you will not be 100%

rruffer avatar Jan 09 '19 16:01 rruffer

Hello, Thanks for the good work. AdminLTE 3 is released and it supports BS4. Will Adminfaces will support BS4?

dguna avatar Jan 20 '21 18:01 dguna