Alex Leong

Results 159 comments of Alex Leong

This is probably a duplicate of https://github.com/linkerd/linkerd/issues/1377 right?

This test script makes requests to all distinct names, causing massive binding cache churn and a huge rate of allocations. It's not surprising that GC is not able to keep...

Hi @xiaoerlyl, unfortunately the finagle thrift client does not set the `dest` request header. Linkerd uses a special filter in order to set this header: https://github.com/linkerd/linkerd/blob/master/linkerd/protocol/thrift/src/main/scala/com/twitter/finagle/buoyant/linkerd/TTwitterClientFilter.scala

Thanks, @adriancole! I think this would be a very simple change to https://github.com/linkerd/linkerd/blob/master/linkerd/protocol/http/src/main/scala/io/buoyant/linkerd/protocol/ZipkinTracePropagator.scala Are you interested in working on this?

Truncating the response sounds great to me

Probably related to https://github.com/linkerd/linkerd/issues/2125

I think the ideal fix here would be a change to `twitter/util`'s flag parsing so that `-` is not treated as a flag. I believe the offending code is here:...

This sounds like a good idea. Pull requests welcome.

Thanks for starting a discussion on this. There's a _lot_ left unspecified in the K8s ingress spec (such as it is) so it's not super clear what the right behavior...

I know @olix0r has been thinking a lot about this and the API around it.