Adam King

Results 110 comments of Adam King

> @phlogistonjohn I'm half way through reviewing this PR. Sorry about the delay. > > @adk3798 I see that you're running this through testing. Can you post the test result...

@phlogistonjohn I think this may be causing a couple test failures https://pulpito.ceph.com/adking-2022-08-12_20:56:57-orch:cephadm-wip-adk-testing-2022-08-12-1411-distro-default-smithi/ ``` 2022-08-13T17:31:56.968 INFO:teuthology.orchestra.run.smithi007.stderr:Invalid command: Unexpected argument '--detailed' 2022-08-13T17:31:56.968 INFO:teuthology.orchestra.run.smithi007.stderr:nfs export ls [--detailed] [] : List exports of a...

> The unit tests at mgr/nfs/tests/test_nfs.py is run by make check? @ajarr yes, mgr/nfs/tests/test_nfs.py is part of mgr tox tests which runs during make check

https://pulpito.ceph.com/adking-2022-08-17_23:17:58-orch:cephadm-wip-adk2-testing-2022-08-17-1543-pacific-distro-default-smithi/ 1 failure from https://tracker.ceph.com/issues/55347 dashboard e2e test appears to have failed taking a host out of maintenance mode. Looks unrelated to PRs in the run.

looks like it's having trouble with the bootstrap-osd keyring in the tests ``` 2022-10-08T00:41:57.370 INFO:teuthology.orchestra.run.smithi149.stderr: stderr: 2022-10-08T00:41:57.364+0000 7fdce9289700 -1 auth: unable to find a keyring on /var/lib/ceph/bootstrap-osd/ceph.keyring: (2) No such...

> looks like it's having trouble with the bootstrap-osd keyring in the tests > > ``` > 2022-10-08T00:41:57.370 INFO:teuthology.orchestra.run.smithi149.stderr: stderr: 2022-10-08T00:41:57.364+0000 7fdce9289700 -1 auth: unable to find a keyring on...

> @adk3798 given that ceph-volume already requires the bootstrap-osd keyring for other operations, I wouldn't add more logic in ceph-volume to detect what keyring is available or not. I think...