hugo-PaperMod icon indicating copy to clipboard operation
hugo-PaperMod copied to clipboard

Update he.yaml

Open idanhazan opened this issue 1 year ago • 4 comments
trafficstars

PR Summary:

This PR includes three types of changes:

  • Completion of Missing Translations: Added translations for previously missing content.
  • Content Corrections: Corrected translations to better reflect the intended meaning.
  • Language Direction Adjustments (RTL): Fixed issues related to the right-to-left (RTL) text direction to ensure proper display and readability.

Please review the changes and let me know if there are any additional adjustments needed. Thank you!

idanhazan avatar Sep 07 '24 07:09 idanhazan

@eisraeli @RealA10N requesting your review

adityatelange avatar Sep 07 '24 08:09 adityatelange

I had two additional questions:

  1. Should we use "דקה 1" instead of "דקה אחת" to maintain consistency with the English version, which uses "1 min" rather than "one min"?

  2. Should we use "מילה 1" or "מילה אחת" instead of just "מילה" to align with the format used for minutes?

In terms of correct Hebrew, it is preferable to use the phrases: "דקה אחת" and "מילה אחת"

idanhazan avatar Sep 07 '24 09:09 idanhazan

IMO there is no need to enforce consistency across languages at this micro level: as long as the meaning is consistent, the exact wording should be in accordance with the laws of the local language.

So I suggest:

מילה אחת

For "1 word", and,

דקה אחת

For "1 min".

Other than that, LGTM!

RealA10N avatar Sep 07 '24 09:09 RealA10N