fix silly typo that triggers my OCD

[tobiabocchi]

Just a simple typo.. Thank you for the wonderful theme!!

What does this PR change? What problem does it solve?

Was the change discussed in an issue or in the Discussions before?

PR Checklist

• [ ] This change adds/updates translations and I have used the template present here.
• [ ] I have enabled maintainer edits for this PR.
• [ ] I have verified that the code works as described/as intended.
• [ ] This change adds a Social Icon which has a permissive license to use it.
• [ ] This change does not include any CDN resources/links.
• [ ] This change does not include any unrelated scripts such as bash and python scripts.
• [ ] This change updates the overridden internal templates from HUGO's repository.

[peakschris]

I've also been seeing this, windows 10, regardless of shell (cmd, bash, powershell)

[sgowroji]

Hi @Vertexwahn, Could you please provide complete steps to reproduce this issue?

[peakschris]

For me, on windows:

git clone https://github.com/bazelbuild/bazel.git
cd bazel
git checkout release-7.2.1 #specific release unimportant
bazel mod graph

displays:

Starting local Bazel server and connecting to it...
<root> (bazel@_)
Γö£ΓöÇΓöÇΓöÇ[email protected]
Γöé   Γö£ΓöÇΓöÇΓöÇ[email protected] (*)
Γöé   Γö£ΓöÇΓöÇΓöÇ[email protected] (*)
Γöé   ΓööΓöÇΓöÇΓöÇ[email protected] (*)
<snip>

[fmeum]

What happens if you pass --charset=ascii? Does your terminal support UTF-8?

[peakschris]

--charset=ascii shows the tables, albeit less nicely:

The terminal does support UTF-8:

wget https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt
cat UTF-8-demo.txt

shows:

[fmeum]

Sounds like Windows requires special API usage for printing UTF-8 to the console: https://stackoverflow.com/a/9337400/297261

If you are interested, you could try integrating WriteConsoleW in WriteToStdOutErr here: https://cs.opensource.google/bazel/bazel/+/master:src/main/cpp/util/file_windows.cc;drc=7f782e3c1a1c4a21beea19c2cedb614be8316e67

Edit: Fixed the reference

[peakschris]

I added this one line to file_windows.cc:

bazel mod graph now outputs:

I think SetConsoleOutputCP could just be called once somewhere from main(), as long as it is not reset elsewhere.

Sorry, I can't submit this as a PR due to CLA.

Chris

[fmeum]

@bazel-io fork 7.3.0

[Wyverald]

Fixed in https://github.com/bazelbuild/bazel/commit/4a5fe6207eb596effc13fe6b8e862727dc03eda6