hugo-PaperMod icon indicating copy to clipboard operation
hugo-PaperMod copied to clipboard

configurable entry summary length

Open vindex10 opened this issue 1 year ago • 1 comments
trafficstars

What does this PR change? What problem does it solve?

Summaries in the entry list are shortened, with hardcoded number of visible rows.

Even though summaryLength can be extended, the visible part in the entry list doesn't change.

In this PR I suggest a way to make it configurable through the template params in hugo.toml.

It should be noted, that this PR is blocked by another pull request, which allows parametrizing theme styles: https://github.com/adityatelange/hugo-PaperMod/pull/1399

... and should be rebased when the 1399 is merged.

Was the change discussed in an issue or in the Discussions before?

no

PR Checklist

  • [ ] This change adds/updates translations and I have used the template present here.
  • [x] I have enabled maintainer edits for this PR.
  • [x] I have verified that the code works as described/as intended.
  • [ ] This change adds a Social Icon which has a permissive license to use it.
  • [x] This change does not include any CDN resources/links.
  • [x] This change does not include any unrelated scripts such as bash and python scripts.
  • [ ] This change updates the overridden internal templates from HUGO's repository.

vindex10 avatar Jan 26 '24 18:01 vindex10

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 26 '24 18:01 sonarqubecloud[bot]

Why not just add this to custom css https://github.com/adityatelange/hugo-PaperMod/wiki/FAQs#bundling-custom-css-with-themes-assets

.entry-content {
    -webkit-line-clamp: <any value>;
}

adityatelange avatar Mar 08 '24 05:03 adityatelange

.entry-content {
    -webkit-line-clamp: <any value>;
}

I guess because the current solution goes against the grain, being completely confusing and incompatible with Hugo's own setup for limiting the length?

I spent past 40 minutes trying to understand what's causing my content truncated, despite everything set up accordingly per Hugo's docs. Only after disabling styling one-by-one in Developer mode in Safari I stumbled upon "webkit-line-clamp: 3;".

wrobelda avatar Apr 19 '24 23:04 wrobelda

I guess because the current solution goes against the grain, being completely confusing and incompatible with Hugo's own setup for limiting the length?

I spent past 40 minutes trying to understand what's causing my content truncated, despite everything set up accordingly per Hugo's docs. Only after disabling styling one-by-one in Developer mode in Safari I stumbled upon "webkit-line-clamp: 3;".

I spent more than 40 mins of time debugging, answering queries for this project.

You cannot restrict number of lines with hugo's ways of limiting length. There are devices of different screen width and on all of them you need the exact same heights of cards you see on home page. Guess how would you do it? By line-clamping.

Spend some time thinking why things are like the way they are instead of telling us importance of your time.

adityatelange avatar Apr 21 '24 15:04 adityatelange

I am letting you know how hard it was to get to understand what’s happening here as a feedback. You instigating I consider my time important here is just your projection and I don’t find that acceptable.

I get that you can’t adjust the number of lines, but one would expect a quirk like this to be documented, especially since you arbitrarily set that number to 3. Author of this PR offered to make this configurable and, as such, explicit, but you rejected it, throwing people like myself under a bus. And when I explain how difficult it is to get to the bottom of this, you get offensive.

wrobelda avatar Apr 21 '24 17:04 wrobelda

@wrobelda you don't get to ask me what to do. You don't like it you don't use it. You're feedback lacks appreciation and is just a rant. Don't expect me to document stuff for you. You're on your own in this foss world. This is a Free software, forkoff and modify it as you like it.

adityatelange avatar Apr 22 '24 04:04 adityatelange