hugo-PaperMod icon indicating copy to clipboard operation
hugo-PaperMod copied to clipboard

Fixed hiddenInHomeList logic to use a boolean.

Open aisotton opened this issue 2 years ago • 4 comments
trafficstars

The previous code would check for the string "true" instead of the boolean true. This made it so that 'hiddenInHomeList: false' would hide a page, instead of showing it.

This fixes this by using a boolean.

What does this PR change? What problem does it solve?

The previous code would check for the string "true" instead of the boolean true. This made it so that 'hiddenInHomeList: false' would hide a page, instead of showing it.

Was the change discussed in an issue or in the Discussions before?

No

PR Checklist

  • [ ] This change adds/updates translations and I have used the template present here.
  • [X] I have enabled maintainer edits for this PR.
  • [X] I have verified that the code works as described/as intended.
  • [ ] This change adds a Social Icon which has a permissive license to use it.
  • [X] This change does not include any CDN resources/links.
  • [X] This change does not include any unrelated scripts such as bash and python scripts.
  • [ ] This change updates the overridden internal templates from HUGO's repository.

aisotton avatar Jul 14 '23 21:07 aisotton

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 14 '23 21:07 sonarqubecloud[bot]

@aisotton with which config file type it was an issue with? yml, json, toml?

adityatelange avatar Jul 15 '23 06:07 adityatelange

It was a toml file. I didn't try the others.

On Sat, Jul 15, 2023 at 12:21 AM Aditya Telange @.***> wrote:

@aisotton https://github.com/aisotton with which config file type it was an issue with? yml, json, toml?

— Reply to this email directly, view it on GitHub https://github.com/adityatelange/hugo-PaperMod/pull/1264#issuecomment-1636682164, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIV6LB3NCCAQNU7F5EFCVTXQIZIDANCNFSM6AAAAAA2K2PBLI . You are receiving this because you were mentioned.Message ID: @.***>

aisotton avatar Jul 15 '23 13:07 aisotton

Are you ok with this change?

aisotton avatar Aug 02 '23 00:08 aisotton