hugo-PaperMod icon indicating copy to clipboard operation
hugo-PaperMod copied to clipboard

update twitter shortcode in example site for new shortcode rule

Open smailzhu opened this issue 3 years ago • 3 comments
trafficstars

What does this PR change? What problem does it solve?

The "twitter_simple" shortcode will soon require two named parameters: user and id.

you can find more detail in https://github.com/gohugoio/hugo/commit/0cc39af68232f1a4981aae2e72cf65da762b5768

Was the change discussed in an issue or in the Discussions before?

PR Checklist

  • [x] This change adds/updates translations and I have used the template present here.
  • [x] I have enabled maintainer edits for this PR.
  • [x] I have verified that the code works as described/as intended.
  • [ ] This change adds a Social Icon which has a permissive license to use it.
  • [x] This change does not include any CDN resources/links.
  • [x] This change does not include any unrelated scripts such as bash and python scripts.
  • [ ] This change updates the overridden internal templates from HUGO's repository.

smailzhu avatar Aug 28 '22 15:08 smailzhu

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 28 '22 15:08 sonarqubecloud[bot]

@smailzhu is this compatible with current min version that is 0.83.0 ?

adityatelange avatar Aug 28 '22 16:08 adityatelange

I haven't try it. But I think it only compatible with 0.89.0 and later Based on the hugo release v0.89.0 notes

updated the Twitter shortcode

Which is based on the issue https://github.com/gohugoio/hugo/issues/8130

The Twitter REST API v1 is no longer active. Please migrate to API v1.1. https://dev.twitter.com/docs/api/1.1/overview.

smailzhu avatar Aug 29 '22 01:08 smailzhu

Fixed with https://github.com/adityatelange/hugo-PaperMod/commit/3ba89eec3f1b3af568ddacccabddfe2d1c78517a

adityatelange avatar Apr 20 '24 17:04 adityatelange