Android-FileBrowser-FilePicker icon indicating copy to clipboard operation
Android-FileBrowser-FilePicker copied to clipboard

Published 20 hours ago • verified publisher icon adityak368

Fix #1293 Support more customizable toc

Open pauloxnet opened this issue 2 years ago • 1 comments

pauloxnet avatar Sep 11 '22 18:09 pauloxnet

This appears to be an implementation of the feature requested in #1293. What happens here depends on what decision is made there.

waylan avatar Sep 12 '22 16:09 waylan

Given the decision made in #1293, I will not be accepting this as-is. However, I am not opposed to including the new config option to allow the user to define the class assigned to the title. After all, we already allow various other classes to be set by the user. Might as well include this one too.

If this is updated (with all checks passing), then I would be happy to accept it. If no action is taken, it will likely be closed.

waylan avatar Apr 18 '23 15:04 waylan

I'll try to work on that in may because tomorrow I'm leaving to go to PyCon US.

pauloxnet avatar Apr 18 '23 19:04 pauloxnet

@waylan I rebased this PR and left only the customizable TOC title class. I renamed this PR because is changed a lot from my original idea.

pauloxnet avatar Jul 26 '23 07:07 pauloxnet

The tests will need to all be passing before we can accept this. Also, the release notes and the documentation need to be updated appropriately.

waylan avatar Aug 07 '23 15:08 waylan

The tests will need to all be passing before we can accept this. Also, the release notes and the documentation need to be updated appropriately.

@waylan I fixed test failures and updated the documentation

pauloxnet avatar Aug 10 '23 07:08 pauloxnet