Overdrive integration broken with Kobo Sync
What happened?
With Kobo Sync enabled, I went to download a book from Overdrive. It downloaded, but shows it is expiring today. On my iPad, in Libby, it shows 21 days left to read (which is correct). Also, removing Kobo Sync (reverting to the original conf file), I get Sync Failed errors. Re-adding Kobo Sync fixed the Sync issue, but reinstated the Overdrive issue. I had to sign out of my Kobo account and sign back in to get it to sync, effectively resetting the Kobo, so had to sign back in to Instapaper, manually load back in side-loaded books, reset font settings etc. So basically a full reset.
How can we see it happen?
Steps to reproduce the issue:
Borrow a book with Overdrive when Kobo Sync is enabled.
What did you expect to happen?
Overdrive to behave as it does without Kobo Sync enabled.
About your setup:
- Booklore version: 1.3.4
- What computer or device are you using? (Windows, Mac, Linux, etc.) : Mac
- Which browser and version? (Chrome, Firefox, Safari, etc.) : Chrome
- How did you install Booklore? (Docker, manual install, etc.) : Docker
Same issue here
Maybe it could help to check what this or for cwa proposes to help with the kobo integrations like overdrive https://github.com/crocodilestick/Calibre-Web-Automated/pull/685
I'm not using booklore (yet!) so I may be misunderstanding how kobosync works on this project, but I had a quick look at KoboResourcesComponent.java and I noticed that that Line 105 is currently be set as "kobo_nativeborrow_enabled": "False" I believe that this needs to be updated to True
It should be a 2 second fix, but as I can't test it I don't want to push a PR.
Adding to say I am experiencing the same issue. Since adding Kobo Sync to Booklore, I am unable to properly sync with overdrive. The library book will appear on the reader, but as expired and unable to be opened.
@jduar could you maybe take a look at this?
I'm not using booklore (yet!) so I may be misunderstanding how kobosync works on this project, but I had a quick look at KoboResourcesComponent.java and I noticed that that Line 105 is currently be set as
"kobo_nativeborrow_enabled": "False"I believe that this needs to be updated to TrueIt should be a 2 second fix, but as I can't test it I don't want to push a PR.
FYI, I rebuilt the image with this change and it alone was not enough to fix the issue.
@jmswangit Unfortunately, I don't think I can help. I don't have access to Overdrive because of the service not being available in my country I think.
I'm not sure whether kobo_nativeborrow_enabled is related though, judging by the fact that that setting is set the same on both Calibre-Web and Komga and users there report the service working.
I did notice that both the pull request from CWA mentioned above and the one associated to this issue (https://github.com/janeczku/calibre-web/issues/3398) on Calibre-Web add a route for "/v1/library/