Adi Roiban comments

Results 556 comments of


                                            Adi Roiban

defer: Expand inline callbacks tests

Thanks for the cleanup. I have merged this as I hope it will help with future cleanup work for deprecated code and with deferred performance improvements.

#7798 Handle non-socket.error in TCP client and invalid port numbers.

There is this GitHub URL https://github.com/pulls/review-requested which shoudl help detect things pending review... you can then filter based on project

PTY tests on macOS are flaky

Reverted in https://github.com/twisted/twisted/pull/12173

example test failure ... not adding link to the build as the build log will expire in 30 days ``` [FAIL] Traceback (most recent call last): File "/Users/runner/work/twisted/twisted/.tox/macos-withcov-alldeps/lib/python3.12/site-packages/twisted/internet/test/test_process.py", line 523,...

#12174 Run benchmarks with with PyPy as well

Is there an official solution for this ? I guess that we might want to run these tests with python 3.12 and later with 3.13 to see if there are...

Expose passivePortRange via cmd args for the FTP command

Thanks for the feedback. I am leaving this to be reviewed by someone else to break the tied. Twisted is a community based project. The code quality and review rules...