Adi Roiban

Results 556 comments of Adi Roiban

I am -1 on hardcoding `www` or adding an external toml file configuration. I am ok with reserving a `.json` for the default DirectoryStore implementaiton. I am using a different...

In the end I added SAN support in a quick and dirty way ... but it works :) ... see https://github.com/twisted/txacme/compare/37-san-support Instead of `server_name` I am using the storage key...

Is there any value in this, when you have certbot?

I see that PyPi is configuredf for ci.yml , while the current file is named ci.yaml This was previously configured ![image](https://github.com/twisted/constantly/assets/204609/279a530a-9dd3-4e0d-8878-4cc404b7b4ab) ------- I have reconfigured PyPI for ci.yaml This is...

I can try do a .dev0 release on https://test.pypi.org/ .... not sure how the versioner part works for testing :( ... but I will give it at try.

I am not familiar with licence files. Is it expected to have the licence file alonside the .py files I see the licence file in the metadata part ``` $...

Hi Wim. I would be happy to review a type annotation PR for this repo :) Anyone with time for this, feel free to send the PR and I will...

It looks like nose is loading the tests before loading the plugins... so you can monkey patch the code ```python def patch_add_flaky_report(self, stream): """ Patch flaky reporting to also write...

One important feature is to make sure that `towncrier check` , when executed for a release branch will make sure the source code has no `$NEXT_RELEASE$` marker ------- The problem...

Hi. Thanks for the report. I think that we should start by using some "reference" command as part of towncrier's GHA YAML file. We currently have this https://github.com/twisted/towncrier/blob/272993f1f4323db8f96ba67926781d753f207ba7/.github/workflows/ci.yml#L161-L165 but this...