Adi Roiban

Results 556 comments of Adi Roiban

@ihaywood3 > If you want /remote/ access to Windows servers, you're reviewing the wrong PR of mine ;-) > > #1274 Hi Ian. I am not very interested in a...

@wiml thanks for the pr. you can ping me if you found random/spurious/flaky tests. My goal in life is to get a solid green for all tests from trunk :)...

I am working on PYPY failures at https://github.com/twisted/twisted/pull/1543 For codecov/project yes, you get a report as soon as the first report is sent by a job... and then it is...

I don't think that you should block on the random CI failures. Just make sure the code from this PR is rock solid and I am sure that it will...

Changes looks good. As long as this is private API, it should be ok. But the tests are failing and I think we need green tests to merge this. Thanks!

This is related to #11567 as we can create new issue templates that can automatically set labels.

Thanks @exarkun for the review. I have updated the release note and updated the tests to count for skipped methods. I have renamed the test_skip.py to test_skipif.py and updated the...

Thanks Niels for the PR. I am trying to run some manual and automated tests for this PR. Is this an issue only with dropbear client? Does it required a...

This is still on my todo list, but for now I am busing with fixing some generic Twisted CI issues

I have executed a small manual test: ``` $ mkdir ssh-keys $ ckeygen -t rsa -f ssh-keys/ssh_host_rsa_key $ ckeygen -t rsa -f ssh-keys/client_rsa $ python docs/conch/examples/sshsimpleserver.py ``` From another terminal...