Adi Roiban

Results 556 comments of Adi Roiban

One option is this recursion... which should work as long as you wrap using `wrappedProtocol` ```python self._handshakeDone = True endProtocol = self._getEndProtocol(self.wrappedProtocol) if IHandshakeListener.providedBy(endProtocol): endProtocol.handshakeCompleted() def _getEndProtocol(self, wrappedProtocol): """ Try...

In this case, as an end user of the library, I know nothing about `ProtocolWrapper`. I am just using `TrafficLoggingFactory` together with `Factory.forProtocol` and an `IHandshakeListener` protocol.

Many thanks Tom for your review. Excellent suggestions. I have applied all your suggestions. This is ready for another review needs-review

Thanks @glyph for the review. My goal was to get something better than the current documentation ... we can make it perfect in follow up PRs :) I don't think...

I had to deal with Twisted context factory about 10 years ago. I got it working somehow, and since then I forgot about it. @glyph if you have time, maybe...

Thanks for the report. I think that currently there is no active maintainer for twisted.names, unfortunatelly. Any help with getting this bug fixed is much appreciated. I can help with...

I have never used the `wrapClientTLS` API. Maybe have an API like `wrapClientTLS(connectionCreator, wrappedEndpoint, waitHandshake=True)` The signature can be `wrapClientTLS(connectionCreator, wrappedEndpoint, waitHandshake=None)` If `waitHandshake` is `None` we can raise a...

Thanks! As long as we keep only the #6960 newsfragment in this PR, I think that we can still make the change.

> Do you mean https://github.com/twisted/twisted/issues/6960 ? Yes. Sorry. It was about #6960