Adi Roiban

Results 556 comments of Adi Roiban

I think that `pip install twisted` will skip the release candidate by default. pip/pypi are using semantic versioning to detect a release candidate. See https://pypi.org/project/Twisted/#history ... the RC are highligted....

The release candidate tag should be named: `twisted-24.02.0rc1` This will trigger a normal release in PyPI. PyPi is smart enought and wil automatically tag this as pre-release. GitHub Releases tool...

@itamarst if it's easier, we can schedule a meeting tomorrow over IRC or Matrix and look at the release process. Let me know what works best for you. I know...

The main reason for checking the "Pre-release" option in GitHub Release is so that the old stable will continue to be the "recommended" version in GitHub UI ![image](https://github.com/twisted/twisted/assets/204609/cd203112-eb81-4412-ba4a-46829bd6cabe)

Thansk for the PR. Do you have time to help reviewing this PR first https://github.com/twisted/twisted/pull/12059 ? In that PR, python 3.13 automated tests are introduced, so that in future PR...

Thanks Heather for the PR. I will give it try. As part of this PT, we will also need to update the set of tests we run on Python 3.13...

Thanks Weezel for the update and your help with Python 3.13 support. Which test is failing on your local dev system? Do you use tox or you run `trial` directly?...

I am not sure what is going on here... Not sure if this is a Twisted bug for 3.13 ...or Python 3.13... or something else. i can see the full...

There is also another issue. On 3.12, all tests are skipped ``` 12:04 $ python --version Python 3.12.1 12:04 $ trial twisted.internet.test.test_inlinecb.ForwardTraceBackTests twisted.internet.test.test_inlinecb ForwardTraceBackTests test_forwardLotsOfTracebacks_312 ... [SKIPPED] test_forwardLotsOfTracebacks_313 ... [SKIPPED]...

Something even better ```diff + +HAVE_PY3_12_OR_OLDER = sys.version_info < (3, 13) class ForwardTraceBackTests(SynchronousTestCase): - @skipIf(sys.version_info > (3, 12), "Needs Python 3.12 or older") + @skipIf(not HAVE_PY3_12_OR_OLDER, "Needs Python 3.12 or...