Folders that are too large for the recycle bin are permanently deleted without any warning
Describe the bug First off, I think it is wildly inappropriate to have the ability to delete files enabled by default. This is not a functionality I would expect in my tool that is primarily used for searching for files on my system (i.e. I think of a file searching tool primarily as a "read" tool, not a "read-write" tool). I don't expect to be able to delete files with just an errant keyboard press while using such a tool (i.e. if I press the Delete key on my keyboard while I am typing into a search box, I expect to delete highlighted text, or text to the right of the Cursor, not to delete folders/files on my system). I would recommend at a minimum that this functionality be turned off by default (i.e. the default state of the "Disable delete features" should be set to "On").
Second, there is a significant bug in Fluent Search's implementation of the delete functionality: If the folder/file that is being searched for is too large for the Recycle Bin, then it is silently, with no warning whatsoever, permanently deleted from the system. Due to this, I just lost a large folder of data without even realizing it was happening.
To Reproduce Steps to reproduce the behavior:
- Create a folder/file that is too large for the Windows Recycle Bin.
- Search for the folder in Fluent Search.
- Press Delete on the Keyboard
- The folder is permanently deleted without any warning.
Expected behavior Under no circumstances should data be permanently deleted from my system without warning. Additionally, file deletion of any kind should be turned off by default.
Screenshots N/A
Desktop (please complete the following information):
- Window 10: Version 22H2
- Fluent Search Version: 0.9.92.998
- Installation source: Microsoft Store
Hey, I am really sorry for the inconvenience! This is a very weird behavior that happens when using some of old delete APIs. This is fixed in version 1.0.x and will be soon available through the Microsoft Store (you can still download it from https://fluentsearch.net)
Thanks for the detailed issue!
Closing as the fix has been released and no further issues were reported. If you're still experiencing this on the latest version, please reopen.