Andy Dienes

`judge` lacks a docstring

1

it's documented in the `Manual` portion of the docs, but considering this is one of the primary exported functions, it should probably also be present in the `Reference` section with...

API to construct MLJ-proper model from standalone model

3

``` julia> enet = ElasticNetRegression() GeneralizedLinearRegression{L2Loss, CompositePenalty} loss: L2Loss L2Loss() penalty: CompositePenalty fit_intercept: Bool true penalize_intercept: Bool false scale_penalty_with_samples: Bool true julia> ElasticNetRegressor(enet) ERROR: MethodError: no method matching ElasticNetRegressor(::GeneralizedLinearRegression{L2Loss, CompositePenalty})...

a la http://www.seas.ucla.edu/~vandenbe/133A/lectures/mols.pdf probably just a matter of adding a dispatch for `y::AbstractMatrix` and stacking the columns but first wanted to see if there is receptiveness to making multiobjective OLS...

box (or just positive) constraints on enet OLS

4

what would it take to support box / positive constraints on the Lasso / ElasticNet solvers? is this compatible with the existing API, and if so where could I get...

generalized / group lasso

1

there are a few other regularized forms of Lasso / ElasticNet I would find useful, like group lasso, trend filtering, generalized lasso (& generalized Tikhonov). is this compatible with existing...

this feels way too magic and prone to errors. just load it as a string and the user should be responsible for parsing

https://github.com/JuliaData/SentinelArrays.jl/blob/fa840f994ae821d921a9973fbd5e244d35102b1c/src/BufferedVectors.jl#L32 I think the piracy here should be avoided if possible. I noticed this when the error message for something like `push!(0, 0)` changed

`join` should not introduce `Missing` types to schema

1

``` julia> using DataFrames julia> df1 = DataFrame([:a => [1,2,3], :b=>[4, 5, 6]]) 3×2 DataFrame Row │ a b │ Int64 Int64 ─────┼────────────── 1 │ 1 4 2 │ 2...

due to recent release `[email protected]`, possible `Arrow.jl` should pin to `1.4.0` until the problem is resolved upstream https://github.com/JuliaStrings/InlineStrings.jl/issues/76 ``` # julia julia> Arrow.write("mwe.arrow", Tables.rowtable((; a = String3["xyz", "123"]))) ``` ```...

add `?` suffix to show on all return paths

1

noticed after https://github.com/apache/arrow-julia/pull/512 was displaying `Union{Missing, Base.CodeUnits}` as just `CodeUnits` without the `?`