Adi Mordo

Results 41 comments of Adi Mordo

@M-i-k-e-l do you remember where did we used the `imperativeCloseExpandable` ? was it the `toggleExpandable` or the `useImperativeHandle` ?

> > @M-i-k-e-l do you remember where did we used the `imperativeCloseExpandable` ? was it the `toggleExpandable` or the `useImperativeHandle` ? > > @adids1221 The changes were in `ExpandableOverlay`. But...

@M-i-k-e-l we spoke about it, you passed the `imperativeHandle` to the `toggleExpandable` but it's still calling `onDismiss` twice. I'll set us another meeting about that.

@M-i-k-e-l Iv'e checked it on my device with screenreader. `focusAccessibility` should be part of both `imperativeCloseExpandable and closeExpandable`. `closeExpandable` is getting called by `Dialog` and it's working as expected. But...

@M-i-k-e-l iv'e checked accessibility both on IOS and Android, working fine for me. I noticed something in IOS that the Modal.TopBar rendered even if it's empty (but only IOS I...

Moved to draft. TODO: check in all the components that are using `ExpendableOverlay`

@Moving this PR to draft for now

@matice2 @JoseAIG @AhmedMaqbool Does the issue reproduce on RN `0.73`? Currently we are supporting RN `0.73`, we will try to check this issue.

@crazyshakalaka Hi, please fill the issue with the necessary data. Currently the issue only described in the title, make sure to fill all the fields thank you. Comment when you...