php-cli icon indicating copy to clipboard operation
php-cli copied to clipboard
verified publisher icon adhocore

Implemented unit test to track the visualisation bug in #127.

Open acataluddi opened this issue 7 months ago • 4 comments

Hi Jitendra,

This pull request doesn't solve the bug but rather contains only the unit test method that I believe reproduces the issue.

I would like you to review and confirm that my understanding of the expected Table.render() method behaviour is correct. Without doubt, the unit test will help validate the actual fixture.

Adriano

acataluddi avatar May 11 '25 09:05 acataluddi

however tests seems failing, please recheck https://github.com/adhocore/php-cli/actions/runs/14956185929/job/42012171472#step:6:48

adhocore avatar May 11 '25 13:05 adhocore

another PR #126 is merged already, i will release a new version once this one gets merged too

adhocore avatar May 11 '25 13:05 adhocore

however tests seems failing, please recheck https://github.com/adhocore/php-cli/actions/runs/14956185929/job/42012171472#step:6:48

Hi Jitendra,

Yes, that's "expected" because I've only implemented the unit test reproducing the bug described in #127.

I haven't had time to dig into it and I was wondering whether it was immediate for you to continue this branch and figure out the solution, as you know the internals.

Thanks, Adriano

acataluddi avatar May 11 '25 15:05 acataluddi

hi Adriano, unfortunately i am unable to pick it up at this time, i have released new version with other PR.

adhocore avatar May 12 '25 02:05 adhocore