Andrew Gerrand

Results 145 comments of Andrew Gerrand

@rahul2393 Are you the right person to review this? Note that the JSON_VALUES implementation pulls in a new module dependency, which according to [the policy](https://github.com/googleapis/google-cloud-go/blob/main/CONTRIBUTING.md#policy-on-new-dependencies) requires an exception. I could...

For someone with time and motivation, an analysis of a variety of block sizes vs differently-shaped data could yield some performance improvements. A good task for someone looking for something...

A better link to the central interface docs: https://godoc.org/upspin.io/upspin

I guess that change shouldn't have closed this.

One possible argument against is that it allows you to effectively specify the same field twice, for example: ``` T{E: E{A: 1}, A: 2} ``` But this case already exists...