ember-simple-auth-oidc icon indicating copy to clipboard operation
ember-simple-auth-oidc copied to clipboard
verified publisher icon adfinis

Can we add PKCE?

Open wuarmin opened this issue 5 years ago • 5 comments

Hello, thanks for this addon. It is great.

For ember apps Authorization Code Flow with PKCE is recommended. Would it be possible to add support for it?

Best regards

wuarmin avatar Aug 18 '20 13:08 wuarmin

@wuarmin that is what is supported.

bjornharrtell avatar Sep 15 '20 18:09 bjornharrtell

@bjornharrtell thank you, are you sure? https://oauth.net/2/pkce/ It's an addition to Authorization Code Flow. I cannot find something related in code.

wuarmin avatar Sep 17 '20 04:09 wuarmin

@wuarmin I'm not 100% sure but I'm successfully using it with two different IdPs that offer Authorization Code Flow with PKCE. As there is no client secret I assumed it would not work if it didn't properly support Authorization Code Flow with PKCE.

bjornharrtell avatar Sep 17 '20 07:09 bjornharrtell

Authorization with PKCE does not work for me (I use IdentityServer4)

turbcool avatar Aug 19 '21 10:08 turbcool

agreed I was mistaken, PKCE is not implemented in this addon (yet)

bjornharrtell avatar Aug 19 '21 11:08 bjornharrtell

Closing this, as PKCE is implemented. Please open a new issue if PKCE does not work out for you.

derrabauke avatar Apr 20 '23 09:04 derrabauke