Adrien Ferrand

Results 168 comments of Adrien Ferrand

Yes, I think this is typically this kind of test suite that should be available for any dns plugin. By exposing a simple API to paramaterize the test suite, it...

I think however that the tests should be written in Python. I have ongoing work about that in fact, for the integration tests. See #6578 and #6541. First because in...

Besides merging master, and correcting a threshold for code coverage, I did not do any functional changes here. So from the code written by @quinot, I am happy with it....

And as part of the maintainers team for Lexicon, I can positively assert that these providers are fully covered for tests about TXT records creation/deletion, that are required to make...

@joohoi, concerning the latest comment of @bmw here, did you studied one or all situations described during your review? What would be the remaining ones?

Regarding the initial review @joohoi made, I think indeed that we can mitigate some points. I think the biggest problem about adding a new dependency is that for OS packages,...

I am not sure it will. We are currently working on #7244 that proposes basically a superior solution because it is automated, and is able to resolve more cases. However,...

Hello! As a first step, you should import logging module in entrypoint, it would fix a lot of failures in tests here.