monzo-python icon indicating copy to clipboard operation
monzo-python copied to clipboard

Add Receipt functionality

Open ghost opened this issue 6 years ago • 6 comments

Very recently Monzo teamed up with Flux to bring paperless receipts to the Monzo App.

I could look into implementing this functionality into the wrapper if others are happy? Or someone else can? 😄

Specifically:

ghost avatar Feb 03 '19 19:02 ghost

Hey, this looks pretty interesting! I'm pretty busy with coursework atm so not sure I can implement this anytime soon but I'd be more than happy to look at any code.

TomAFrench avatar Feb 03 '19 22:02 TomAFrench

Hey, this looks pretty interesting! I'm pretty busy with coursework atm so not sure I can implement this anytime soon but I'd be more than happy to look at any code.

@TomAFrench Hey there! Yes I am busy with coursework myself so the progress with probably be slow 😅

ghost avatar Feb 03 '19 22:02 ghost

Unfortunately, it looks like monzo-python would only be able to read receipts which it has created itself.

I'm kinda struggling to see many use cases for this endpoint with this restriction in place. I'd say its worth implementing for completeness but if we can't see retailer-made receipts I can't see what a user would put in a receipt which can't be already added as metadata or notes.

TomAFrench avatar Feb 03 '19 22:02 TomAFrench

Unfortunately, it looks like monzo-python would only be able to read receipts which it has created itself.

I'm kinda struggling to see many use cases for this endpoint with this restriction in place. I'd say its worth implementing for completeness but if we can't see retailer-made receipts I can't see what a user would put in a receipt which can't be already added as metadata or notes.

@TomAFrench Yes exactly, currently at this time I believe there are only 4 merchants which are creating receipts. The endpoint is mostly for creating your own receipts. As you have pointed out, it does seem kind of pointless as this type of data could just be appended as metadata or notes.

I made a quick mockup of what possible functionality might look like.

See last 3 functions at the end of monzo.py

ghost avatar Feb 04 '19 00:02 ghost

Looks pretty nice, If you make this into a pull request I can point out a couple of changes which need to be made (eg. currently the user won't ever know the external_id).

It's worth keeping in mind that the request needs a different encoding than normal. I'm not sure those requests you're making will work but it should just be a small change to account for this.

TomAFrench avatar Feb 04 '19 01:02 TomAFrench

Afternoon @TomAFrench, here is the pull request #28.

ghost avatar Feb 04 '19 12:02 ghost