Adele Morrison

Results 111 comments of Adele Morrison

Did you find this documentation that @navidcy recently made? https://cosima-recipes.readthedocs.io/en/latest/contributing.html#reviewing-existing-pull-requests I think it would be great to expand this step: > - Clone the repository or the fork that the...

I'm not sure I feel super strongly either way on the renaming the repo topic, but just to note ([from here](https://docs.github.com/en/enterprise-cloud@latest/repositories/creating-and-managing-repositories/renaming-a-repository)): > When you rename a repository, all existing information,...

I vote for the wiki and delete/shift over the readthedocs.io page. That way everything is at the same github repo link.

No, I suggest moving the info from readthedocs.io to the [github wiki page](https://github.com/COSIMA/cosima-recipes/wiki). Then delete the readthedocs. Though maybe there is some good reason to have it there that I...

I prefer the wiki, because then everything is at the same weblink, and it's easy to navigate back to the code. But I can see the benefit of requiring review...

Wiki is at https://github.com/COSIMA/cosima-recipes/wiki, which has a 'Code' link in the top bar to take you back directly to the recipes. Readthedocs is at https://cosima-recipes.readthedocs.io/en/latest/. I always find it tricky...

Do you mean skip this plot? We could do that, but I feel like it's useful to show the user what we've got as of this point in the code,...

@hrsdawson and @navidcy, thanks for the review. I've included all of your suggestions above now. Are one of you happy to approve?

Perhaps this is useful: https://github.com/raphaeldussin/xoverturning. It has a 'rotate velocities to True North' option. Rather than removing whole plots, what about just adjusting the latitude limit to only show south...

It never closes, because precipitation minus evaporation is not zero at each latitude. i.e. there is net evaporation from the Southern Ocean (about 1 Sv I think) and this falls...