universe icon indicating copy to clipboard operation
universe copied to clipboard

Flow: enable `experimental.enforce_local_inference_annotations` option

Open mrtnzlml opened this issue 1 year ago • 2 comments

The goal of this task is to enable the following config option in .flowconfig:

- experimental.enforce_local_inference_annotations=false
+ experimental.enforce_local_inference_annotations=true

This project currently has 10 errors after enabling this option that must be fixed.

See Flow 0.184.0 release notes: https://github.com/facebook/flow/releases/tag/v0.184.0

Acceptance criteria

  1. The Flow option experimental.enforce_local_inference_annotations is enabled.
  2. The PR follows the project conventions.
  3. All CI checks pass, and all code review comments are addressed.

Hits for successful completion of this task

  1. Enable experimental.enforce_local_inference_annotations in .flowconfig.
  2. Run ./x flow to see the new errors (should be ~10)
  3. Start investigating and fixing the errors by adding correct Flow annotations.

How to install and run this project

git clone --depth=100 [email protected]:adeira/universe.git
cd universe
corepack enable

chmod +x ./x
./x install

To run JavaScript tests:

./x tests

For more information, please visit README.md located at the root of this project. If you get lost, you can also start a new discussion. 😎

mrtnzlml avatar Sep 14 '22 03:09 mrtnzlml

Hello, I would like to work on this task

manastelavane avatar Oct 13 '22 15:10 manastelavane

Hi @manastelavane! 👋 I've assigned you to this task. Please let me know in case you need any help or advice. I am happy to help. My recommendation is to check the latest Flow release as well as it includes relevant information regarding this issue: https://github.com/facebook/flow/releases/tag/v0.189.0

mrtnzlml avatar Oct 13 '22 15:10 mrtnzlml