backbone-fundamentals icon indicating copy to clipboard operation
backbone-fundamentals copied to clipboard

Published 20 hours ago • verified publisher icon addyosmani

Bring back in post-merge fix changes

Open mogarick opened this issue 11 years ago • 5 comments

The chapter Backbone & JQuery Mobile goes after Exercise 3 but it's also repeated again after Jasmine chapter. This problem is not present on the PDF version.

mogarick avatar May 13 '13 06:05 mogarick

Could you confirm if this is an issue in just the PDF/ePub generated here or in the O'Reilly version (purchased)?

addyosmani avatar May 21 '13 08:05 addyosmani

it also repeated twice in .md file and also I noticed jasmine repeated too

eugeneglova avatar May 21 '13 09:05 eugeneglova

@eugeneglova I've pushed fixes for this over into https://github.com/addyosmani/backbone-fundamentals/tree/merge-fix. Could you help double check that this update is okay? It's mostly the compiled ePub and index file we need to review.

It looks like some recent changes to:

chapters/09-bbb.md chapters/10-mobile-applications.md chapters/11-unit-testing.md chapters/12-qunit.md chapters/13-sinonjs.md chapters/14-resources.md chapters/15-conclusions.md chapters/16-appendix.md

caused the issues with repetitions. We can push merge-fix to live/master, but I'll need to go back through these files and manually merge back in the changes that were introduced. I'll see if there was a specific PR that caused this so we can rollback as needed.

addyosmani avatar May 25 '13 12:05 addyosmani

@addyosmani I've checked .md and now it looks better :-) thanks

eugeneglova avatar May 25 '13 12:05 eugeneglova

Thanks. Pushing these changes live but keeping this open for the fix effort.

addyosmani avatar May 25 '13 12:05 addyosmani