stream-lib icon indicating copy to clipboard operation
stream-lib copied to clipboard

Published 20 hours ago • verified publisher icon addthis

I think should check value before set it to bits.

Open wangchuan2008888 opened this issue 7 years ago • 2 comments

RegisterSet class set and updateIfGreater method update value, but have not check weather the value greater than 0x1f.

may be that is a bug.

wangchuan2008888 avatar Mar 17 '17 09:03 wangchuan2008888

This looks like a nice improvement. Can you add a test that would have failed without the check? We aren't sure that the additions you made to the test would have failed even with the old code.

abramsm avatar Mar 17 '17 15:03 abramsm

I write back the RegisterSet, now the test would be FAIL, Sorry for fresher to GitHub, I donot know is there better way to show you this change

wangchuan2008888 avatar Mar 17 '17 19:03 wangchuan2008888