QDigest does not implement neither Serializable nor Externalizable

[staslev]

Hi guys,

I was wondering if the fact that QDigest does not implement neither Serializable nor Externalizable is intentional? I'm afraid it prevents QDigest from being serialized using ObjectOutputStream, which could be very useful (and for better or worse is still a quite common way to serialize stuff).

Unless I'm missing something, it would be pretty straight forward to fix, since QDigest already provides a serialize and deserialize methods, they just need to be exposed as part of the standard Java serialization interfaces.

What do you think? It it makes sense, I'd be more than willing to create a pull request.

-Stas

[tea-dragon]

Can't think of any intentional reason other than possibly reducing code noise. It seems reasonable to add and shouldn't cause any backwards compatibility issues that I can think of.

I know we've done the same for other data structures before as needed.

[abramsm]

Our QDigest implementation has fallen behind latest implementations available. Doesn't necessarily need to be added to this ticket but we should look into updating our implementation to match best available.

On Tue, Jan 26, 2016 at 6:54 PM Ian Barfield [email protected] wrote:

Can't think of any intentional reason other than possibly reducing code noise. It seems reasonable to add and shouldn't cause any backwards compatibility issues that I can think of.

I know we've done the same for other data structures before as needed.

— Reply to this email directly or view it on GitHub https://github.com/addthis/stream-lib/issues/102#issuecomment-175338950.