Addison
Addison
I moved this post to Discussions/Ideas. It can be decided at a moment of mutual agreement whether to delete this file or not.
This is a very good idea. I totally agree to move the hardcoded values from XML files to Magento Configuration. The same modification should be done for Price Alerts and...
I would revise the labels and comments for this PR. @luigifab also requested a few good changes. Once we agree the labels and comments we can add the translation phrases.
I'm also waiting for the small change requested from "Cron settings" to "Cron Settings" but I have to insist because it is left to wait..
Indeed, I can create a commit with the change. Good tip. Before adding new translations, it would be good to discuss their wording. Since we are in a cron setting...
> Can this be merged to 19.x? I don't think it would create a problem. a rebase must be done. I will take care of the Backend part because it...
There is no rush to approve it. I'll have a few comments related to this PR.
Before getting this merged we should discussed the PR #1434 too. At least we have the same way of handling exceptions adapted to the new variants of PHP.
Let's rebase the PR to 19. Sury dropped this month the support for Debian 9 and you cannot install other PHP versions anymore. Debian 10 comes with 7.3 and Debian...
I confirm what @kiatng said. I recently faced the implode function in an old PHTML file and the error did not appear anywhere. When I changed Exception to Throwable the...