Ambassador icon indicating copy to clipboard operation
Ambassador copied to clipboard

1.21 vanilla client/server support

Open CursedHawk opened this issue 1 year ago • 4 comments

Hi,

i found bug when trying to connect to Paper 1.21 server with Ambassador installed.

[18:05:40 ERROR]: [server connection] CursedHawk420 -> surv: exception encountered in com.velocitypowered.proxy.connection.backend.BackendPlaySessionHandler@41f0b4d8 io.netty.handler.codec.CorruptedFrameException: Error decoding class com.velocitypowered.proxy.protocol.packet.AvailableCommandsPacket Direction CLIENTBOUND Protocol 1.21 State PLAY ID 11

Uninstalling Ambassador makes it able again for vanilla clients to connect paper servers, but modded 1.20.1 clients tring connect to forge servers wont work anymore.

Could you please add support for 1.21? Thank you, btw very nice plugin, works great for a long time 👍

CursedHawk avatar Jun 27 '24 16:06 CursedHawk

Velocity supports forge 1.20.2 and onwards without Ambassador. What you are looking for is a server side mod to fix the available command arguments issue. My mod PCF solves this but hasn't been ported to that version yet.

adde0109 avatar Jun 27 '24 16:06 adde0109

The problem is that vanilla clients cant connect to paper servers with ambassador installed on Velocity.

CursedHawk avatar Jun 28 '24 12:06 CursedHawk

I have a similar Problem. If i install Ambassador i neither can join my Paper Servers nor my Forge Servers. If i remove Ambassador i can join my Paper Servers again, but if i try to join the Forge Server i get the Error with something like "Denied Vanilla Client" even if i am using a forge modded Client.

CREW8 avatar Jul 20 '24 15:07 CREW8

I'm having this problem too. Here's the Velocity log. https://mclo.gs/wlRNOMz

Someone seems to have discovered why. https://github.com/PaperMC/Velocity/issues/1365#issuecomment-2196096966

Illusionika avatar Aug 02 '24 08:08 Illusionika

I'm having this problem too. Here's the Velocity log. https://mclo.gs/wlRNOMz

Someone seems to have discovered why. PaperMC/Velocity#1365 (comment)

I have a similar problem as well. Any way to fix this?

TerroFlys avatar Sep 12 '24 18:09 TerroFlys

我也遇到了这个问题。这是 Velocity 日志。 https://mclo.gs/wlRNOMz 似乎有人发现了原因。 PaperMC/Velocity#1365 (评论)

我也有类似的问题。 有什么办法解决这个问题吗?

deop

Illusionika avatar Sep 13 '24 00:09 Illusionika

I'm not entirely sure what I am doing, but I did manage to solve the issue in Ambassador.

See patch below: https://github.com/adde0109/Ambassador/compare/v1.4.4...Mac898:Ambassador:patch-bypass-argument-id-issue

Mac898 avatar Oct 12 '24 08:10 Mac898

I'm not entirely sure what I am doing, but I did manage to solve the issue in Ambassador.

See patch below: v1.4.4...Mac898:Ambassador:patch-bypass-argument-id-issue

This fixed it for me as well, thank you

Willsr71 avatar Oct 13 '24 18:10 Willsr71

I havent tested it with Forge backend on 1.20.2+ If I get around to testing it and verify it at least superficially works, I will create a PR for it.

Mac898 avatar Oct 14 '24 05:10 Mac898

Havent been able to solve this yet but the issue seems to be that the lobby is a vanilla (paper) server.

TerroFlys avatar Oct 22 '24 11:10 TerroFlys

A fix has been released with v1.4.5.

adde0109 avatar Dec 18 '24 20:12 adde0109