adda
adda copied to clipboard
Scripts for figures
Improved scripts for figures on PRA requirements
Thank you for contributing to ADDA. Please remove the Italic text (_..._
) throughout this template after following the corresponding instructions
Description
Improved python scripts for the reproduction of updated figures from the article "Vector Bessel beams: General classification and scattering simulations" according to requirements of Physical Review A journal.
Related issues
Related to #209
Types of changes
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist
- [x] I have read the contributing guidelines
- [x] The new code complies with the existing code style.
- [x] The code compiles correctly in all relevant regimes (at least,
make seq
) - [x] The new code does not rely on any Fortran or C++ sources or is disabled by
NO_FORTRAN
orNO_CPP
preprocessor macros, respectively. - [x] The change neither adds or removes files; otherwise, these changes are reflected in
README.md
in corresponding folders. - [x] No warnings appear during debug compilation (at least,
make seq OPTIONS=DEBUG
, but betterdevtools/build_debug
) or they are discussed below - [x] Tests pass locally with my changes (at least,
sh comp2exec seq
intests/2exec
, but betterdevtools/test_new [seq]
). If any errors appear, they are discussed below. - [x] I have added tests that prove my fix is effective or that my feature works. And these tests pass. This includes new command line in suite files in
tests/2exec
(and potentially new ignore patterns). In some cases, it is desirable to add new tests totests/equiv
. - [x] I have added/extended necessary documentation (if appropriate). If suggesting changes to the manual, I have used "Track changes" in the doc file.
- [x] I have looked through all changes introduced by this pull request (line by line), using
git diff
or, better, some GUI tool, to ensure that no unexpected changes are introduced.
Further comments
In the future: the doi and other info of the article is still needed for the readme file.