plugin.video.vrt.nu icon indicating copy to clipboard operation
plugin.video.vrt.nu copied to clipboard

Published 20 hours ago • verified publisher icon add-ons

Fix integrated landscape view in Arctic Horizon skin

Open mediaminister opened this issue 3 years ago • 8 comments

This fixes https://github.com/add-ons/plugin.video.vrt.nu/issues/822 and reintroduces https://github.com/add-ons/plugin.video.vrt.nu/issues/783

Using xbmcplugin.setContent('seasons') enables the Integrated Landscape View, but in that case Arctic Horizon skin doesn't pick up the ListItem metadata in Kodi Player, so this PR introduces https://github.com/add-ons/plugin.video.vrt.nu/issues/783 again.

mediaminister avatar Oct 20 '20 19:10 mediaminister

@vermope @piejanssens Can you test this PR again please with the most recent https://github.com/jurialmunkey/skin.arctic.horizon

Here is a zip package from this PR: plugin.video.vrt.nu-2.4.5-landscape-d26163a.zip

I think https://github.com/add-ons/plugin.video.vrt.nu/issues/783 is fixed. If you can confirm, I think this PR can be merged.

mediaminister avatar Feb 08 '21 13:02 mediaminister

@mediaminister Works perfectly! Seems it's the default view now, did not had to change the view. Thanks!!

vermope avatar Feb 08 '21 13:02 vermope

I got the same https://github.com/add-ons/plugin.video.vrt.nu/issues/783 bug again. It's not fixed apparently, but the bug only occurs when you play an episode after selecting the season in the integrated landscape view.

mediaminister avatar Feb 10 '21 16:02 mediaminister

We may want to verify if there is a bug in Estuary wrt. folder icons.

dagwieers avatar Feb 10 '21 21:02 dagwieers

Tested the build from the zip provided by @mediaminister in this PR and I don't see a difference between Arcitc Horizon master and 0.5.58.

Both showing this OSD while playing VOD: Schermafbeelding 2021-02-11 om 08 01 08

piejanssens avatar Feb 11 '21 07:02 piejanssens

@piejanssens You should test with a series with multiple seasons, select a season in the integrated landscape view and play an episode. In this specific case the episode info is missing in the OSD.

mediaminister avatar Feb 11 '21 08:02 mediaminister

My bad, I knew it was too early 😴 I can report that the issue is still as described in #783

piejanssens avatar Feb 11 '21 08:02 piejanssens

I finally found the cause of https://github.com/add-ons/plugin.video.vrt.nu/issues/783 The missing OSD info is related to the use of the built-in PlayMedia function in https://github.com/jurialmunkey/skin.arctic.horizon/blob/master/1080i/Includes_View_53_Seasons.xml When using PlayMedia, there is no metadata passed from the selected ListItem. To get this fixed, the add-on needs to request the metadata again from the VRT NU api:

I found out skin.video.siren is setting metadata in the play function to workaround this bug. This kind of workaround is not desirable in the VRT NU add-on because we need an extra API request for that and this will slow down player start.

https://github.com/add-ons/plugin.video.vrt.nu/issues/822#issuecomment-717771303

mediaminister avatar Feb 11 '21 17:02 mediaminister