plugin.video.vrt.nu icon indicating copy to clipboard operation
plugin.video.vrt.nu copied to clipboard

Published 20 hours ago • verified publisher icon add-ons

Returning from "Go to program" fails, ends up in Videos

Open dagwieers opened this issue 4 years ago • 9 comments

Describe the bug

When going back after selecting "Go to program" from the context menu, Kodi doesn't go back to the recent/offline listing but ends up in Kodi's Videos window.

This appears to be a bug in Kodi rather than an add-on issue.

We use the ActivateWindow(window,dir,return) call which should bring you back to the originating listing when you go back.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Recent items or Soon offline listing
  2. Select an episode and right-click, then choose Go to program
  3. In the program episode listing, go back
  4. Notice you end up in Kodi's Videos window

Expected behavior

Kodi should go back to the originating Recent items or Soon offline listing.

Additional context

  • Operating system: LibreELEC v9.0.2
  • Kodi version: v18.2
  • Addon version: v2.2.0
  • Using a VPN: no
  • Country you are using the addon from: BE

dagwieers avatar Aug 13 '19 20:08 dagwieers

This was reported upstream at: xbmc/xbmc#16492

dagwieers avatar Aug 13 '19 21:08 dagwieers

We implemented a work-around using XBMC.Container.Update(dir).

dagwieers avatar Oct 21 '19 13:10 dagwieers

I am going to close this, as I have no hope this will be fixed in Kodi.

dagwieers avatar Oct 21 '19 13:10 dagwieers

Thanks to @enen92 there is a fix for this in Kodi: https://github.com/xbmc/xbmc/pull/17893

dagwieers avatar May 21 '20 20:05 dagwieers

The merged PR is for Matrix, I proposed it now for Leia as well.

dagwieers avatar Jun 18 '20 14:06 dagwieers

I am going to close this, as I have no hope this will be fixed in Kodi.

Never stop hoping! :)

michaelarnauts avatar Jun 18 '20 15:06 michaelarnauts

This has now been merged into the Leia branch !

dagwieers avatar Jul 15 '20 12:07 dagwieers

@mediaminister I cannot remember, is there a need to go back to using ActivateWindow()? Or do we keep Container.Update().

Related issues:

  • Added go to program context menu (https://github.com/add-ons/plugin.video.vrt.nu/pull/425)
  • v2.3.0 issue tracker (ResumePoints, UpNext, overlay, cosmetics) (https://github.com/add-ons/plugin.video.vrt.nu/issues/616)
    • Indicates that ActivateWindow() is more reliable after Player closes
  • Use ActivateWindow to update container (https://github.com/add-ons/plugin.video.vrt.nu/pull/628)
    • There was still the issue with URLs ending with a number (https://github.com/xbmc/xbmc/issues/16516), which was also closed

dagwieers avatar Oct 14 '20 22:10 dagwieers

No, there is no real need to go back to using ActivateWindow(), the current implementation works well enough.

In the past, there were timing issues updating resume points while Kodi Player was closing. But I implemented wait_for_resumepoints and this fixed it. So, most issues and comments regarding container updates before https://github.com/add-ons/plugin.video.vrt.nu/pull/652 are outdated.

FYI, you can find detailed information about the built-in functions at https://codedocs.xyz/AlwinEsch/kodi/page__list_of_built_in_functions.html

mediaminister avatar Oct 15 '20 07:10 mediaminister