react-mobile-picker
react-mobile-picker copied to clipboard
Parent Scroll fix, TS definition, and Wheel support
Hey Adcent, Hope you are having a good day.
This is a PR aimed to fix the following problems:
- Touching a column results in triggering the scroll event on the parent and therefore moves the page, this is possible to observe in the example project on iOS
- When moving the items, it is not possible to use the white space below the last item or the space above the first item to move the items; this is frustrating as you need to just touch the middle item to be able to confidently move the picker
-
package-lock.json
not being included in the project - Fixed incorrect selection for when the final transition point is in between two items.
And adds the following features:
- Adds wheel support. It is not possible to use this component reliably on desktop
- Adds TS definition, making it possible to use this project on TypeScript codebases without writing a custom typing
This PR solves or addresses the following issues and PRs:
- #26
- #39
- #32
Hi, @falahati , Thanks for contributing to this lib. I have read your changes and started a review with two suggestions, and I'll merge this PR after your new committing. If you have any questions, feel free to leave a comment.
Sure @adcentury, go for it.
But I don't see any comments right now. Are you not done with the review yet?
@falahati Sorry, I forgot to submit it. Now you can check it.
I have also added a fix for issue #32 and made some cleanups. please take another look and decide on the changes. thanks