Adrien Barbaresi

Results 412 comments of Adrien Barbaresi

@AdamQuadmon @DesBw Thanks for your feedback, I am open to review a pull request on this.

When the input string is too short is it more difficult to guess but there is indeed an issue here, simplified Chinese characters are obviously not Japanese.

Your command just writes a file named `.txt` in the target directory. `--keep-dirs` is useless if you download files from the internet, there are no directory to keep. It is...

You can also have a look at the code to see which additional parts are discarded, and you can run the benchmark in the `tests/` folder to see how extraction...

Hi @vodkaslime, indeed. It is not currently possible to pass a suitable argument to `buffered_downloads`, there is a missing link between the `config` (older) and `options` (newer) formats. The code...

@vodkaslime The PR above fixes the issue. A description could be added to the docs.

Hi @Honesty-of-the-Cavernous-Tissue, while your idea is good in general order matters for these XPath expressions. I advise against it, you would have to be sure to pass the tests and...

@Honesty-of-the-Cavernous-Tissue You'd still need to fix type hinting for Python 3.13 and test of there is a regression on the benchmark (see tests Readme).

@Honesty-of-the-Cavernous-Tissue Are you still working on the PR?

@AdamQuadmon Thanks for the substantial PR, it's great that you included tests and documentation. Could you please make sure the tests pass for older Python versions? I don't think the...