react-data-grid icon indicating copy to clipboard operation
react-data-grid copied to clipboard

Resize column via keyboard

Open godon019 opened this issue 2 years ago • 2 comments

Closes #3320

godon019 avatar Oct 07 '23 13:10 godon019

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.21%. Comparing base (fe98d87) to head (e14b606).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3357   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          47       47           
  Lines        5087     5091    +4     
  Branches      727      727           
=======================================
+ Hits         4996     5000    +4     
  Misses         91       91           
Files Coverage Δ
src/DataGrid.tsx 99.34% <100.00%> (+<0.01%) :arrow_up:

codecov[bot] avatar Oct 07 '23 14:10 codecov[bot]

Hi folks, thanks for working on this! Please let me know if I can help at all.

One bit of feedback on the changes so far: ideally resizeColumn and getColumnWidth would be accessible from anywhere and not limited to specific handlers like onCellKeyDown so consumers have flexibility in how it is exposed (for example, column widths could be rendered within the grid and made editable via input elements). Perhaps the methods could be present on the CalculatedColumns themselves, or exposed via imperative handle on the grid?

Thanks for all the work on this fantastic project!

kycutler avatar Jan 30 '24 23:01 kycutler