react-data-grid icon indicating copy to clipboard operation
react-data-grid copied to clipboard

feat: scrolling uses smooth transition effects by default

Open Wxh16144 opened this issue 2 years ago • 4 comments

Great open source project, I made some changes, want to make the scrolling default with transition animation, hope you can accept my PR, thanks in advance:

like: 7.0.0-beta.30 effect

https://github.com/adazzle/react-data-grid/assets/32004925/5e58c5b9-dd0d-4874-b056-cbd79ca2ecc6

Wxh16144 avatar Jul 07 '23 07:07 Wxh16144

Unfortunately this doesn't work well with, for example, holding down arrow keys Recording 2023-07-07 at 11 32 36

nstepien avatar Jul 07 '23 10:07 nstepien

Unfortunately this doesn't work well with, for example, holding down arrow keys

I'm glad you replied, but can we consider passing the smooth transition as an option, for example, when scrollToCell is called via ref, for example

gridRef.current.scrollToCell({ idx: 123 }, { behavior: 'smooth' });

Wxh16144 avatar Jul 07 '23 16:07 Wxh16144

Sounds good to me

nstepien avatar Jul 07 '23 17:07 nstepien

I've submitted some changes, I need your help CR.

Wxh16144 avatar Jul 13 '23 09:07 Wxh16144

Please check https://github.com/adazzle/react-data-grid/issues/3308#issuecomment-2832287242

amanmahajan7 avatar Apr 26 '25 14:04 amanmahajan7