react-data-grid icon indicating copy to clipboard operation
react-data-grid copied to clipboard

Remove scrollToCell helper

Open amanmahajan7 opened this issue 2 years ago • 1 comments

Replaced scrollToRow/scrollToCell with a new scrollToCell method

New logic

  • Set scrollToCell state
  • Render an additional cell
  • Scroll to the cell using scrollIntoView
  • Clear scrollToCell state

amanmahajan7 avatar Mar 01 '22 23:03 amanmahajan7

Codecov Report

Merging #2851 (17fbb92) into main (5a94124) will increase coverage by 1.98%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
+ Coverage   94.05%   96.03%   +1.98%     
==========================================
  Files          38       39       +1     
  Lines        1244     1237       -7     
  Branches      396      398       +2     
==========================================
+ Hits         1170     1188      +18     
+ Misses         74       49      -25     
Impacted Files Coverage Δ
src/hooks/useCalculatedColumns.ts 99.16% <ø> (ø)
src/DataGrid.tsx 95.05% <100.00%> (+5.05%) :arrow_up:
src/ScrollToCell.tsx 100.00% <100.00%> (ø)
src/utils/domUtils.ts 50.00% <100.00%> (ø)

codecov[bot] avatar Apr 06 '22 18:04 codecov[bot]