react-data-grid icon indicating copy to clipboard operation
react-data-grid copied to clipboard

Feature: Add support for flex column width

Open amanmahajan7 opened this issue 2 years ago • 4 comments

Column now supports CSS grid units including auto (default), fr, %, max-content etc. To handle virtualization, a flex column is assigned a width of (80px) and the actual width is calculated after the grid is rendered.

amanmahajan7 avatar Feb 22 '22 23:02 amanmahajan7

Codecov Report

Merging #2839 (151d724) into main (dd90693) will increase coverage by 0.32%. The diff coverage is 95.23%.

:exclamation: Current head 151d724 differs from pull request most recent head edc46e7. Consider uploading reports for the commit edc46e7 to get more accurate results

@@            Coverage Diff             @@
##             main    #2839      +/-   ##
==========================================
+ Coverage   94.02%   94.35%   +0.32%     
==========================================
  Files          38       38              
  Lines        1256     1258       +2     
  Branches      403      405       +2     
==========================================
+ Hits         1181     1187       +6     
+ Misses         75       71       -4     
Impacted Files Coverage Δ
src/HeaderCell.tsx 90.00% <0.00%> (ø)
src/HeaderRow.tsx 100.00% <ø> (ø)
src/style/cell.ts 100.00% <ø> (ø)
src/DataGrid.tsx 91.26% <95.00%> (+0.84%) :arrow_up:
src/hooks/useCalculatedColumns.ts 100.00% <100.00%> (+0.83%) :arrow_up:
src/hooks/useGridDimensions.ts 100.00% <100.00%> (ø)
src/hooks/useViewportColumns.ts 85.71% <100.00%> (+2.85%) :arrow_up:

codecov[bot] avatar Feb 22 '22 23:02 codecov[bot]

Hi, is this PR going to be merged?

qujck avatar Jun 21 '22 12:06 qujck

Hey 👋 Thanks so much for all the great work on this PR. Any chances this PR will get merged soon?

gugu91 avatar Jul 20 '22 10:07 gugu91

I am also quite keen to see this merged in please

danhab99 avatar Jul 28 '22 15:07 danhab99