react-data-grid icon indicating copy to clipboard operation
react-data-grid copied to clipboard

context-menu The right-click menu is not closed

Open reai99 opened this issue 3 years ago • 6 comments

Describe the bug

To Reproduce

1.grid to right-click 2. Click elsewhere in the grid 3. The right-click menu is not closed Link to code example:https://adazzle.github.io/react-data-grid/#/context-menu

Expected behavior

Environment

  • react-data-grid version: 4.0.8
  • react/react-dom version:^15.6.2

Additional context

image

reai99 avatar Dec 13 '21 07:12 reai99

Anyone working on this? I have a fix. can I take this?

jayakrishnancn avatar Dec 20 '21 17:12 jayakrishnancn

Click inside the grid the menu is not closed

reai99 avatar Dec 28 '21 11:12 reai99

I have a solution 1、ContextMenu getting component instances const props = { ref: e => this.contextMenu = e, id: "grid-context-menu", } 2、listen for table row clicks,do the following this.contextMenu?.setState({ isVisible: false })

reai99 avatar Dec 29 '21 11:12 reai99

Can someone merge this fix into the master branch?

JokerMartini avatar Jan 04 '22 14:01 JokerMartini

Can someone merge this fix into the master branch? Wait for the publisher to update @jayakrishnancn

reai99 avatar Jan 04 '22 14:01 reai99

Understandable. Are there not multiple people that manage the repo or is it just the one guy who verifies all the pull requests and merges

JokerMartini avatar Jan 05 '22 12:01 JokerMartini