audio-output-switcher icon indicating copy to clipboard operation
audio-output-switcher copied to clipboard

Shorten name by using ellipsis.

Open TurboGit opened this issue 5 years ago • 6 comments

But this is the only way to get readable sink otherwise we just have the prefix which are all equals. "Audio interne Stéréo analogique".

TurboGit avatar Apr 22 '20 12:04 TurboGit

Not sure this is the best solution but as least I cannot now properly select the proper sink.

TurboGit avatar Apr 22 '20 12:04 TurboGit

Thank you for your merge request, I'll review in more detail in the following days.

adaxi avatar Apr 23 '20 08:04 adaxi

Hello ! Any news about this ?

TurboGit avatar Jun 05 '20 16:06 TurboGit

Hi! I haven't had a lot of time to focus on my side projects.

Altough I am running an older version of the extension of my system ellipsis are automatically for long menu strings, this is not the case on more recent versions of Gnome? (I'm still running 3.30)

See below a screenshot of my system:

Screenshot from 2020-06-06 19-54-19

Could you share a screenshot of what is happening on your system perhaps?

adaxi avatar Jun 06 '20 18:06 adaxi

No I have ellipsis but at the end. But the ellipsis are coming after a common long prefix (maybe because of French translation), so I have many entries like:

Audio interne Stéréo analogique...
Audio interne Stéréo analogique...

Because real names are:

Audio interne Stéréo analogique on arthur
Audio interne Stéréo analogique on salon

Where atrthur and salon are computer names on my network.

TurboGit avatar Jun 06 '20 18:06 TurboGit

I misundertood what you intended to do (sorry) ! I though you were adding ellipsis at the end of the string, and I was not undertanding why that would solve your issue. After running the name of your devices in the fuction you wrote I get it now. I should have read the code more carefully ;)

End result: Audio int...analogique on arthur

I have mixed feelings about this because I feel that I might be solving your use case, but breaking some one else because the string is now cut in the middle. I will need to think about this, one way out would be to make this an option, but I would like to avoid that.

adaxi avatar Jun 07 '20 21:06 adaxi