pin_code_fields icon indicating copy to clipboard operation
pin_code_fields copied to clipboard

Weird gap between confirm dialog content and question mark

Open the-eric-kwok opened this issue 2 years ago • 1 comments

image

PS: The question mark is not in my dialogContent argument and I think dialog should not add this for me.

the-eric-kwok avatar May 17 '22 18:05 the-eric-kwok

@the-eric-kwok that's the default pastedTextStyle color. Try pastedTextStyle: Theme.of(context).textTheme.bodyMedium or pastedTextStyle: TextStyle(color: Theme.of(context).colorScheme.onSurface).

The question mark gets added by default. But I agree, this shouldn't be done by the widget. It makes it difficult to translate to certain languages, like Arabic or Chinese. It would make more sense to let dialogContent replace a placeholder (e.g. $).

Maybe create a dialogContentBuilder option for more control. (e.g. Widget Function(BuildContext, String?))

dennismuench avatar May 19 '22 06:05 dennismuench

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 17 '22 16:08 stale[bot]