adapt_authoring icon indicating copy to clipboard operation
adapt_authoring copied to clipboard

Re-factor: Use an image file for images which do not have a thumbnail

Open brian-learningpool opened this issue 9 years ago • 3 comments

This is currently a base64 string.

brian-learningpool avatar Sep 21 '15 11:09 brian-learningpool

I would recommend to always show an image for assets as it is very tedious to work with assets that have no thumbnail. If there is no thumbnail generated, I would fallback to the original image and use this.

I also recommend that for simple thumbnail creation from uploaded images we should not only depend on ffmpeg as it requires the user to manually install ffmpeg. There are quite some nice npm packages available that could be used under the hood and installed with npm during setup.

https://www.npmjs.com/package/jimp https://www.npmjs.com/package/sharp

lc-thomasberger avatar Dec 01 '17 09:12 lc-thomasberger

I had a look for something like this in the past, but didn't find anything great. Very up for removing the ffmpeg dependency.

taylortom avatar Dec 08 '17 17:12 taylortom

Ive split off your comment here into another issue @lc-thomasberger #1860

canstudios-louisem avatar Feb 02 '18 15:02 canstudios-louisem