adapt_authoring
adapt_authoring copied to clipboard
adaptlearning
Password reveal
I've added a password reveal to the main login page using the material design SVGs https://material.io/tools/icons/?style=baseline
#2219
OK, I've moved it over to Font Awesome and made sure it works in IE and Edge.
I'll do another PR for the user profile icon.
@Link2Twenty Fab thanks, I'd be happy for the user profile icon change to be part of this PR if you'd like as it makes more sense alongside these changes and is small :)
@canstudios-nicolaw sorry, I've only just noticed your response I've made another PR #2384
@Link2Twenty It looks like both PRs contain very similar Less. It would be good if that could be put in one place that was used by both the login and the user profile. I'm not sure off the top of my head where that would be but can have a look tomorrow.
I'd guess adapt_authoring/frontend/src/core/less/forms.less
We'd have to change the templates so the styles could be a little more generic but that's fine.
I was just having a look and thinking about frontend/src/modules/user/less/ and having a new file called "sharedUserStyles.less" or similar. Since both of the less files are in that directory anyway. I think I'd be equally happy for it to go in forms.less
The third location in the original Issue is adapt_authoring/frontend/src/modules/userManagement/ so outside of the user directory might be best, if we want to use the same styles again, of course.
Hi guys, sorry to jump onto this late.
The original issue (#2219) asks for a password reveal in places where the password is being saved to the database, i.e. on user creation or change. This PR adds it to the login screen – this isn't functionality I've noticed on any of the big websites. Have we general consensus for this to be added here?
@tomgreenfield Google login forms (like Gmail) have a way to reveal passwords, though I can't find anything about it in the material spec.
Also, as @canstudios-nicolaw said Edge and IE add the reveal functionality themselves.
@tomgreenfield @Link2Twenty
I think Tom makes a good point, and I think it is best to discuss issues before working on them to avoid this sort of thing, and we should ask ourselves if we want changes before putting them in. Generally our better defined/higher priority issues are on the bugpatch milestone.
That being said, I know we have implemented this sort of thing before on some of our products, and IE/Edge do this as standard. I would be happy for it to go in. Tom do you feel strongly otherwise?
@canstudios-nicolaw, you've caught my drift. Was mainly opening the discussion to avoid feature creep and/or security concerns.
I read somewhere a while back that companies tend to avoid toggles on their web-based login forms due to users being able to exploit password managers' auto-fill functionality to reveal plain text passwords. No strong feelings either way from me though.
I am happy for this to go in. I will give it a proper test/approve as soon as 0.9.0 is out
I think this is a great feature, shouldn't we have this feature in our latest release?
