adapt_authoring icon indicating copy to clipboard operation
adapt_authoring copied to clipboard

Asset management; Non-Admin users: Delete button should be hidden on other user's assets

Open canstudios-kent opened this issue 6 years ago • 3 comments

Expected Behaviour

Admin type users can edit and delete any user's assets when in Asset management. Non-Admin type users can only delete their own asset in Asset management.

Actual Behaviour

The "Delete" button is still visible on other user's assets. Nothing happens when clicking "Delete", though a 500 error does appear in the browser dev tool. Can the "Delete" button be made to only be visible on assets that the user has uploaded?

Steps to Reproduce

  1. Log in as a Course Creator user.
  2. Navigate to Asset management.
  3. Click an asset. Notice that the "Delete" buttons is visible.
  4. Click "Delete". Notice that the asset remains visible.

Versions

  • Authoring Tool Version: 0.8.0
  • Framework Version: 2.4.0

canstudios-kent avatar May 30 '19 09:05 canstudios-kent

@tomgreenfield What are your thoughts on this?

canstudios-nicolaw avatar May 30 '19 14:05 canstudios-nicolaw

No strong feelings either way, @canstudios-nicolaw. In other places have we not attempted to hide functionality and instead displayed a permissions dialog?

tomgreenfield avatar May 31 '19 10:05 tomgreenfield

Also deleted asset (that the course creator owns) are not shown in asset manager. Should have a greyed out image. I'm happy if course creators can soft delete assets they do not own. Problem seems to be that behavior is in inconsistent. Issue #1450 is still happening.

dancgray avatar Jul 15 '19 14:07 dancgray