adapt_authoring icon indicating copy to clipboard operation
adapt_authoring copied to clipboard

Current snackbar implementation should be renamed toast

Open taylortom opened this issue 6 years ago • 3 comments

Related to: #934


I think the terminology has gotten a bit mixed up here.

The main difference between the two is essentially interaction; toasts are used to display information to the user and require no interaction, snackbars straddle the area between toasts and alerts, and present a message along with an action (in a less interrupting way than an alert).

In my original demo (which took heavy inspiration from Google's material implementation), the snackbar was a full-width notification bar that was embedded in the page, as opposed to a smaller pop-up overlay (see below screenshots for comparison -- note my toast demo didn't include the action button).


Because notifications are a pretty important UI/UX component, I've asked to book some of @kirsty-hames time to come up with some designs/AD for these to make sure we've got something that fits in nicely with the current UI, but is also consistent and logical for users. We will also need to review the current use of alerts, and switch to a different style where appropriate.

We'll report back when we've got something to show 😄


Further reading:

Snackbar

screenshot 2019-02-06 at 10 35 07 screenshot 2019-02-06 at 10 35 32

Toast

screenshot 2019-02-07 at 12 08 01

taylortom avatar Feb 12 '19 12:02 taylortom

For v0.7.0, it probably makes sense to revert all use of snackbars back to alerts.

taylortom avatar Feb 12 '19 12:02 taylortom

Not sure about reverting for 0.7.0 as it is already merged and it is only a naming issue. I would suggest we add a deprecation warning in the code and fix it in the upcoming 0.7.1 release.

lc-thomasberger avatar Feb 12 '19 14:02 lc-thomasberger

By revert, I just mean temporarily change the code in editorView.js and projectView.js to use alert again. There's no need for any deprecation warnings, let's just not publicise the feature until we've sorted everything.

When it comes to the next release, I don't see the code really changing (besides anything needed for styling), just the naming.

taylortom avatar Feb 12 '19 14:02 taylortom